• jol
    link
    fedilink
    arrow-up
    32
    ·
    6 months ago

    QA and Code reviews do different jobs. Manual and automated testing will not notice your code is shit, so long as all test cases pass.

    • rockSlayer@lemmy.world
      link
      fedilink
      arrow-up
      7
      arrow-down
      1
      ·
      6 months ago

      That’s what QA engineering is for. They are integrated into the dev team and they pull double duty with QA and code review.

      • jol
        link
        fedilink
        arrow-up
        11
        ·
        6 months ago

        In my company QA is dedicated to manual and automated tests. I haven’t met many QA engineers who could effectively review any of my code.

          • jol
            link
            fedilink
            arrow-up
            2
            ·
            6 months ago

            Sorry, I’m not native English. What would be the difference?

            • rockSlayer@lemmy.world
              link
              fedilink
              arrow-up
              1
              ·
              6 months ago

              A title is just something a company calls a particular job. A role is what that job actually is. So a lot of jobs might be called “QA engineer”, but not fitting the intended role

              • jol
                link
                fedilink
                arrow-up
                2
                ·
                6 months ago

                Gotcha. I mean, all software engineers should do some QA engineering, but we have QA engineers who are the experts and “QA coaches”.

        • Marketsupreme@lemm.ee
          link
          fedilink
          arrow-up
          2
          ·
          6 months ago

          As a qa engineer this makes me feel better about myself. Because I’m included on reviews but never know what I’m looking at.

          • jol
            link
            fedilink
            arrow-up
            2
            ·
            6 months ago

            I’ve worked in places where QA we people with no coding knowledge who just clicked around looking for bugs, as well as places where QA never did that, only automated tests. And then there are places that believe hiring QA is useless, because “everyone should do QA”.

            • Marketsupreme@lemm.ee
              link
              fedilink
              arrow-up
              1
              ·
              6 months ago

              This is my first big career job and in my limited experience I think I support the idea of a second pair of eyes, with a hybrid on automated testing. It seems more comprehensive and thorough than having a single person work on a task (minus code reviews).

              • jol
                link
                fedilink
                arrow-up
                1
                ·
                6 months ago

                In the end it comes down to the size of the team/company.