Notably for this community is the inclusion of the “lemmy-site” class on the #app div

  • Zetaphor@zemmy.ccOP
    link
    fedilink
    English
    arrow-up
    3
    ·
    1 year ago

    That’s what kicked this whole thing off! I realized I was going to have to do all kinds of dumb stuff just to identify if I was actually looking at a lemmy site with any amount of certainty, and then it grew from there

      • Zetaphor@zemmy.ccOP
        link
        fedilink
        English
        arrow-up
        1
        ·
        1 year ago

        Please check the PR and let me know if there’s anything I missed as far as good candidates for CSS targeting. I tried to use a light touch while being mindful of the different ways people may want to style both visible and parent structures

        • mershed_perderders@sh.itjust.worksM
          link
          fedilink
          English
          arrow-up
          1
          ·
          1 year ago

          the thing that bugged me (and continues to do so) is the different uses of .container-lg among the pages.

          It is used differently between the community, search, main, and alert/messages area and it killed me trying to figure out the spacing relative to each use. In some cases I gave up…

          • Zetaphor@zemmy.ccOP
            link
            fedilink
            English
            arrow-up
            3
            ·
            1 year ago

            I just pushed a commit for the more-btn suggestion. The others look a bit more involved, but I think they are do-able. However I’m going to leave them for a separate PR as I would like this make sure this one gets into 0.18. That said I should be able to look into them next, just want to break this off and get it merged.

          • CodingAndCoffee@lemmy.world
            link
            fedilink
            English
            arrow-up
            1
            ·
            edit-2
            1 year ago

            Having all the various interaction buttons labeled, having a separate left-hand vs. right-hand footer location etc. would be helpful.

            Being able to have a link from a comment to scroll up to the parent or up to the root like HackerNews would be fantastic but is currently kinda difficult without a lot of looping (slow on big threads)