I patched together some version of this using nested dictionaries:

var abilities: Dictionary = {
	AbilityData.Trigger.BEFORE_ATTACK : {},
	AbilityData.Trigger.ON_ATTACK : {},
	AbilityData.Trigger.ON_HIT : {},
	AbilityData.Trigger.ON_KILL : {},
	AbilityData.Trigger.ON_DEATH : {},
	AbilityData.Trigger.ON_JUMP : {},
	AbilityData.Trigger.PASSIVE : {}
}

with each value being another key:value pair of { "ability_id": <ability-node> } so I can keep a reference to the Ability node and use dictionary functions like .has() to check if a character has a specific ability:

func has_ability(ability_data: AbilityData) -> bool:
	if abilities[ability_data.trigger_type].has(ability_data.id):
		return true
	return false

Then when a trigger fires, it calls this (I omitted the return code):

// Activates all abilities with the specified trigger type. Returns an array containing each ability that was activated this way.
//trigger_type is an enum
//data is just a resource containing things like position, target, ability owner, etc
func trigger(trigger_type: AbilityData.Trigger, data: AbilityActivationData) -> Array[Ability]:
	var abilities_to_activate: Dictionary = abilities.get(trigger_type)
	
	// Loops through the list of Ability nodes.
	for ability in abilities_to_activate.values():
		ability.activate(data)
		abilities_activated.append(ability)

This seems to work, but it still gives me that tickling sensation that it could be a little cleaner.

I think I understand…

Instead of the player iterating through and calling all of its abilities, the ability just connects directly to whichever signal it needs on the player?

My current setup is to add each Ability as a node to the player, so right now it follows the “call down, signal up” adage that I hear everyone say. What would be a good way to implment the other way? I assume I should rework my current setup otherwise it’d be “signal down, signal up”?

Win11 doesn’t let you past setup if you dont have an internet connection.

Walls are in shambles rn

Epic, I generated a film summary for fun:

I switched to heroes of the storm and I’m actually finding it more fun than league has been lately. Games are quicker and more straightforward, also has MULTIPLE MAPS!!

Wow that answers none of the actual concerns regarding Vanguard. At least they openly confirmed that they dont care about their Linux players.

Well I’ll be damned!

Try forge, it has AI you can play against if your friends don’t wanna play.

Oh hey, a Star Wars The Gathering mechanic got ported to the actual game!

Here’s an absolute banger build I cooked up:

• Max range + Elemental Sandstorm.
• Plague Keewar modded for Viral (innate), Gas, Electric. Melee Exposure in the arcane slot (it activates every time you nado, and works with Elemental Sandstorm).
• Helminth Sickening Pulse over anything other than his tornado.

Basically spin around the tileset vacuuming up as many enemies as you can. After the tornado ends, cast Sickening Pulse immediately. Funny business ensues.

It actually does pretty well in steel path missions, but it does almost no damage to high armour units, even with 10 corrosive stacks. Also completely useless against Overguard units, since for some reason Elemental Sandstorm doesn’t seem to apply to them.

Just finished building my [[Gonti, Lord of Luxury]] deck… This is an interesting sidegrade. The extra colours are nice, although it’ll make it harder to go big mana with [[Cabal Coffers]] and crew. I guess that’s why they gave him the first ability.

Also this is a really cool artwork!

Treasure Shelob :o

Thanks for your input! The other commenters pointed out that I can use Godot’s is_instance_valid() function to check if the bullet’s owner exists before attempting to call anything on it, so will be reworking the system to use #2 + that.

Definitely sounds like the way to go the more I think about it. Thanks!

The longer I’m using the signal chain the more I’m wanting to rework it to just be a reference lol. Good point with checking if the instance is valid, if any other errors come up I could just patch around them in a similar fashion.

That said, you can probably simplify your signal code if you connected the bullet killed_enemy signal directly to the player’s on-hit handler. It seems like the weapon on-kill handler is redundant?

Ah I see what you mean, killed_enemy(enemy-object) signals directly to the player which can then pass that enemy to it’s abilities if needed. You’re correct that the weapon signal is mostly redundant, it was just the easiest node to connect to the bullet’s signals, as it’s responsible for spawning them.

I think I’ll change the whole system to just use a reference. Thanks for your input!

I’m curious how this community feels about Vanguard? I had issues with it when valorant released as well as a lot of my friends, so will probably not be playing league after it’s forced onto the game.

Wow that was incredibly well made, thanks for sharing!

You’re probably right, but it’s an alternative for people who don’t.

Ooze’s Approach