• twei
    link
    fedilink
    arrow-up
    10
    ·
    3 months ago

    is “step in and help review a few PRs” really that helpful? like… oh great, now this one person that i don’t trust is telling me that the other person that i don’t trust made some code that i should merge

    • solarvector@lemmy.ml
      link
      fedilink
      arrow-up
      2
      ·
      2 months ago

      How does one become trusted? If they regularly review and provide feedback that you agree with it can really speed up the process, even if you’re still double checking.

    • chebra@mstdn.io
      link
      fedilink
      arrow-up
      1
      ·
      3 months ago

      @twei Well of course as an outsider you can’t call the “All clear”. But you can raise concerns and ask questions about binary files, obfuscated parts, you can checkout the branch and run it, … if you find something, say it, it’s easy to verify your claim. Saying “I didn’t find any problem” is not so helpful, as that is also not so easy to verify, and doesn’t prove the absence of problems. But pointing to a problem proves the existence of problems.