reply with features and bug fixes you’d like to see in Philthy, the lemmy fork that runs on this instance. no guarantees I’ll get to any of them soon, but particularly low-hanging fruit and well-liked features can be prioritized.

  • mountainriver@awful.systems
    link
    fedilink
    arrow-up
    7
    ·
    8 months ago

    This could very well just be me not understanding Lemmy yet, but I find it tricky to find the new comments. I mean if I’ve read a thread and see that there are 10 new comments since last I read the tread, I would like to be able to find them. Or maybe there already is?

    In SCOOP they were marked with [new] in read. I liked that.

    • 200fifty@awful.systems
      link
      fedilink
      English
      arrow-up
      5
      ·
      8 months ago

      Seconding this! I’d love some kind of highlight system. It seems like it sort of highlights recent comments very subtly, but it doesn’t seem to have anything to do with whether I’ve read them

    • David Gerard@awful.systems
      link
      fedilink
      English
      arrow-up
      4
      ·
      edit-2
      8 months ago

      that’s a very nice feature, much as in Reddit when you have gold

      i think sometimes they’re highlighted?

      • self@awful.systemsOPM
        link
        fedilink
        arrow-up
        5
        ·
        8 months ago

        yep! they are currently highlighted but the UI for it is very insufficient (a subtle change to the post’s background color) and it feels very inconsistent. there’s also the bug where your own posts are considered unread posts in the thread, which isn’t physically possible, and makes the unread mechanism a lot less useful. I feel like there’s a lot of low hanging fruit here that could make unread posts better very quickly, though I do want to check and see if the API has any bad surprises lurking

    • froztbyte@awful.systems
      link
      fedilink
      English
      arrow-up
      4
      ·
      8 months ago

      Having used it with the web interface and Mlem, it’s definitely there but it’s also awkward to use. I get the impression this is due to the APIs exposed for posts but haven’t checked as yet. Definitely a good suggestion!

  • self@awful.systemsOPM
    link
    fedilink
    arrow-up
    6
    ·
    8 months ago

    search desperately needs to be reworked. maybe it should even be an external service that just indexes off of the lemmy database and uses the API to pull in federated results when they’re not cached locally?

    fuck, why do I keep wanting to spin up a search engine

    • self@awful.systemsOPM
      link
      fedilink
      arrow-up
      4
      ·
      8 months ago

      does anyone have strong positive or negative feelings about SearXNG? I haven’t looked into its API, but a local Lemmy and federation plugin for it might be a cool way to get better search

        • David Gerard@awful.systems
          link
          fedilink
          English
          arrow-up
          2
          ·
          edit-2
          8 months ago

          i can’t even find the code, so … my psychic powers tell me it’s the most basic thing like probably the DB’s inbuilt text search

          • froztbyte@awful.systems
            link
            fedilink
            English
            arrow-up
            3
            ·
            8 months ago

            is it this (which appears to be the repo for the treehouse.systems operations), or is there a mastodon search feature/entity also called treehouse (and thus is not this)?

            • David Gerard@awful.systems
              link
              fedilink
              English
              arrow-up
              3
              ·
              8 months ago

              yeah that’s Treehouse. it’s a mastodon fork that doesn’t bother trying to upstream any more because Eugen is that kind of lead dev

              • froztbyte@awful.systems
                link
                fedilink
                English
                arrow-up
                3
                ·
                8 months ago

                I keep wanting to sit down and find the time to go through the impls and see which I want to run (because I want to move my main off masto.social), and … ugh. I hope not everything is this kind of thing

                • self@awful.systemsOPM
                  link
                  fedilink
                  arrow-up
                  5
                  ·
                  8 months ago

                  there is something seriously wrong with fediverse software devs, I said, developing fediverse software

  • David Gerard@awful.systems
    link
    fedilink
    English
    arrow-up
    5
    ·
    7 months ago

    Images in comments are tiny and awkward to expand. Please make the images display as hyperlinks so I can centre-click on them to open the image full-sized in a new tab, or do whatever else with it.

  • Mii@awful.systems
    link
    fedilink
    English
    arrow-up
    5
    ·
    edit-2
    8 months ago

    Fix the bug that you get logged out when refreshing the page sometimes – I’ve noticed this on both Firefox and Safari. The token still exists (at least it’s present in document.cookie as jwt), but for some reason it doesn’t get sent anymore, so Lemmy thinks you’ve been logged out.

    I’ve actually looked into this already, but didn’t get very far, especially because it doesn’t even happen all the time.

    Honestly, just storing it in localStorage instead of as a cookie might work …

  • self@awful.systemsOPM
    link
    fedilink
    arrow-up
    4
    ·
    8 months ago

    better federation health logging; a section in the instances page to see logs for the result of the last ~5 or so incoming/outgoing federation attempts with another instance

  • David Gerard@awful.systems
    link
    fedilink
    English
    arrow-up
    4
    ·
    7 months ago

    here’s one that’ll take a bit more thought:

    philthy needs a facility to put in alt-text for images

    and a (default on) setting to warn you when you didn’t

    this already exists in mastodon, that’s quite good actually (includes Tesseract OCR), might be a guide

    • Mii@awful.systems
      link
      fedilink
      English
      arrow-up
      4
      ·
      7 months ago

      I thought you could already do that with the markdown syntax ![alt text](url). Or is this one of those GitHub-unique markdown features?

      • David Gerard@awful.systems
        link
        fedilink
        English
        arrow-up
        3
        ·
        7 months ago

        ooh I didn’t know that

        needs an interface though

        also that’s probably not how Mastodon etc do it, and it would be nice if images worked over the fed

    • self@awful.systemsOPM
      link
      fedilink
      arrow-up
      3
      ·
      7 months ago

      I was thinking about something like this recently! I generally like how mastodon does it, so that’s a good starting point

  • froztbyte@awful.systems
    link
    fedilink
    English
    arrow-up
    4
    ·
    8 months ago

    I was wiped when i got home yesterday 😅

    here’s the ones I gathered from various thread mentions:

    • modtools local-posts view
    • user flairs (non-federated to start)
    • repo and docs renames (I believe these have been done)
    • a review of the existing containers/container build flow, to see what’s in there
    • CI: open question as to preferred CI system, feedback welcome
    • button to allow auto-subbing users to new subs being created (strikes me that this would also involve user prefs work, to allow users to control that). might also open the door to an invite feature?
    • self@awful.systemsOPM
      link
      fedilink
      arrow-up
      5
      ·
      8 months ago

      is it weird that I kind of want to start with (very limited, probably moderator-assigned) flairs? it’s like the least important feature but it’s one that I miss a lot

      • David Gerard@awful.systems
        link
        fedilink
        English
        arrow-up
        5
        ·
        edit-2
        8 months ago

        user-assigned flairs per sub are great fun, i feel like being a shill for Big Basilisk again

        mod-assigned ones were useful on reddit buttcoin, whereas here we’d probably just get sick of their shiit and ban them

    • froztbyte@awful.systems
      link
      fedilink
      English
      arrow-up
      3
      ·
      7 months ago

      repo and docs renames (I believe these have been done)

      so, taking a look at this (because it seems like a good one with which to dive into the repo and gain a broader familiarity/see all the pieces), quite a bunch of places all across the source and docs that mention lemmy and use lemmy in element/crate/resource names:

      ❯ rg -icI lemmy | numsum; rg -il lemmy | wc -l
      3741
      411
      

      tackling it would be best in stages, I think. both because in general I’m not a big fan of gigantic branches (being a complete pain to review, and absent really really good testing it’s easy for things to slip through), and because that’s just this repo even

      for a staged rename of things, probably makes sense to try tackle subsystems one at a time? would we want to tag versions for each stage completion?

      • self@awful.systemsOPM
        link
        fedilink
        arrow-up
        3
        ·
        7 months ago

        I want to hold off on this for a bit since it will impact our ability to grab commits from upstream; for now I’d recommend we keep lemmy as a legacy symbol and use philthy in new development. once we’re in a good place for this, I imagine it makes sense to do it in stages, in an outside-in pattern — that is, we’d start by renaming things like the executable that’s very visible but breaks relatively little, then gradually make more internal, breaking changes

        • froztbyte@awful.systems
          link
          fedilink
          English
          arrow-up
          3
          ·
          7 months ago

          that’s a fair point too. will probably take a little while to find/develop some patterns for do now vs do later

      • froztbyte@awful.systems
        link
        fedilink
        English
        arrow-up
        3
        ·
        7 months ago

        even just looking at the list of places the name got used… oof. some deeeeeeply baked assumptions in here

  • self@awful.systemsOPM
    link
    fedilink
    arrow-up
    3
    ·
    7 months ago

    oh I keep forgetting to log this one: move the i_love_jesus microdependency into a backend workspace crate (to prevent a potential security issue) and rename it (just cause)

    • self@awful.systemsOPM
      link
      fedilink
      arrow-up
      4
      ·
      7 months ago

      all interested parties should carefully evaluate the crate named i_love_jesus that only Lemmy depends on and also i_love_jesus_macros, a crate of compiler macros that will run on your machine when Lemmy is compiled

      • self@awful.systemsOPM
        link
        fedilink
        arrow-up
        3
        ·
        8 months ago

        I believe it’s this bit of code:

          if local_site_data
            .blocked_instances
            .iter()
            .any(|i| domain.to_lowercase().eq(&i.domain.to_lowercase()))
          {
            Err(LemmyErrorType::DomainBlocked(domain.clone()))?
          }
        

        which gets blocked_instances filled in from the database and domain from the connecting instance. so it’s just a case insensitive string match of everything in the block list against the exact hostname given by the connecting instance as given by ActivityPub – presumably that layer takes care of ensuring the provided hostname is actually the instance’s domain name. so in short I have to do a bunch of stupid shit to block an instance thoroughly, and good luck if I want to block a domain and all of its subdomains

        • froztbyte@awful.systems
          link
          fedilink
          English
          arrow-up
          4
          ·
          8 months ago

          reading that made me flinch

          it’s the exact same thinking I see from a lot of node devs (“just slap chained ops on it to express the logic! it’ll be fine. won’t ever need any complexity!”)

          • self@awful.systemsOPM
            link
            fedilink
            arrow-up
            3
            ·
            8 months ago

            you’re gonna hate me but this style of code is usually my jam

            however, the fact that it’s a conditional whose true branch essentially crashes the task for something that happens frequently (this pattern is everwhere in lemmy, and it’s why my logs are almost nothing but long stack traces) is truly godawful

            • froztbyte@awful.systems
              link
              fedilink
              English
              arrow-up
              4
              ·
              8 months ago

              oh I understand the appeal: it is rapid to express on the fly without breaking flow and enumerating through failure cases. and, for a bit of leeway, there is the upside that rust’s rich return styles affords better actual expression/handling

              but ime each site the pattern gets used for barely holds out at that approach over time (for all but the very simplest cases), and you always discover this far later, when the appropriate context has gotten paged out of all relevant peoples heads

  • froztbyte@awful.systems
    link
    fedilink
    English
    arrow-up
    3
    ·
    7 months ago

    Am I missing something, or does the default web ui not have any kind of way to get to bookmarks (indicated as stars in the control elements)?

  • froztbyte@awful.systems
    link
    fedilink
    English
    arrow-up
    3
    ·
    8 months ago

    Hmm. So, pinned threads are a thing, but just thought (from the kagi thread, David’s post about apologists specifically) maybe pinned comments could also be valuable/useful?