• N3Cr0@lemmy.world
    link
    fedilink
    arrow-up
    9
    ·
    1 year ago

    Lecturer: “Always comment your code.”

    Student: “The code documents itself!”

    Also student: [see screenshot]

    • fsniper@kbin.socialOP
      link
      fedilink
      arrow-up
      3
      arrow-down
      2
      ·
      edit-2
      1 year ago

      It’s not the real issue. I introduced that while anonymizing the data. It’s that a 3-5 liner code became a huge switch case by just incrementing the code and never thinking how it should be done. This was caused by like 15 engineers in time :)

      Something like below would be huge improvement:

      subs1 = ["cluster1", "cluster2"]
      if subs1.contains(clusterName) return subs1
      
      
    • aktenkundig
      link
      fedilink
      arrow-up
      3
      ·
      1 year ago

      There’s a download button in the top right. Not really convenient though, as you then need to go find the downloaded picture yourself.

      • Tangent5280@lemmy.world
        link
        fedilink
        arrow-up
        4
        ·
        1 year ago

        Thank you, this helps, although jerboa really should have a button for full res right next to the download button.

      • fsniper@kbin.socialOP
        link
        fedilink
        arrow-up
        1
        ·
        1 year ago

        It is, but If you review 3 lines of pr and not the whole 50 lines of the file without thinking of the overall picture, this happens. I got this while reviewing a pr like this. And most probably I approved similar prs for this file in the past. Shame on me too…